Fix #394: Make import work with Terra dev version #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garrison Thanks, we should probably port this over here Qiskit/qiskit-ibmq-provider#1135 ? |
|
That would be a fine alternative to this, yes. It is a bit more complicated but might cover some corner cases that this does not. @mtreinish |
Pull Request Test Coverage Report for Build 2545475155
💛 - Coveralls |
mtreinish
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
This should be sufficient and should get what we need. I just took the regex from packaging for elsewhere because it handles grouping all the components of a pep440 compliant version string. But in this case we really don't need to worry about the dev version or a post release suffix since this is just used to tell which api to use.
|
Thank you @garrison! |
rathishcholarajan
added
the
Changelog: Bugfix
blakejohnson
pushed a commit
to blakejohnson/qiskit-ibm-runtime
that referenced
this pull request
May 26, 2023
* Fix flag error. * Fix enum type conversion. * Remove __int__ conversion>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #394
Details and comments